Add StatsD support #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, I glanced over the code and don't have any specific feedback. Happy to get this merged. Could I trouble you to update the README file to reflect the change and include an example of use? |
Sure thing, I've added some info to the README. Let me know if that looks 🆒 |
|
Merged this into master and it will make the next release. For now: Thanks for the contribution @callumj. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for switching the reporting backend to StatsD by specifying
-backend statsd. When specified this will use the StatsD backend (default to CW) and report similar metrics.This implementation uses the Datadog StatsD client which supports tagging when sent to a compatible server like the Datadog agent. To support regular StatsD implementations I've added
-statsd-tagsmove the segmentation by pipeline and queue to a tag.